Displaying image based on four toggles
March 9, 2007 12:00 AM
Thanks for the complement (veteran).Not sure you should have asked. Remember this advice is worth what you pay for it. ;-)First it looks like it will work. But here are some things I would to do simplify the code.1. general rule, never separate the initialization from accumulation. Move the Initialize action to the betinning of Add Variables. Change its name to Compute Total. You get rid of one action and it is easier to read the code. Notice that I missed your initializing the variable! Someone following behind you might too.2. I would put all the image related actions in the same group unless you need the Hide somewhere else all by itself. i.e. move all the Hide All actions to the beginning of the Show Table group. That gets rid of one group and 2 more actions.3. Since you already have separate groups for Select and Bold, I would move all the code from remaining two actions to the groups. i.e. move the Add Variables and Show Table actions to be inside the Bold and Select groups. Now you have just one place to look for different sets of actions, not 2.4. You can make an argument for keeping the Add Variables separate from Show Table. I am torn here. You could combine them based on what you have shown but maybe you haven't shown all. 5. I probably would have put all the images in one group and had a single action. This has + and -. The - is that with 2006 it is difficult to drag the images around by themselves. 2007, just hold the Alt key down. The + is that to add more images, you just drop them into the Static Group and you are done! No additional actions. If you do this, you have 3 fewer actions but one more group.If you plan on anyone printing these pages from a IE 6.0 try it out. There is a print problem with images or actions in a group. I can't remember which. Problem is solved by combining them. 2006 issue. Have not tested in 2007.(Action Group) Set Select Set Select Var True: Sets blnSelect = 1 Set Select Var False: Sets blnSelect = 0 Run Add Variables Run Show Table (Action Bold) Set Bold Set Bold Var True: Sets blnBold = 2 Set Bold Var False: Sets blnBold = 0 Run Add Variables Run Show Table (Action Group) Add Variables Initialize intState: Set intState = 0 Add blnSelect: Adds blnSelect value to intState Add blnBold: Adds blnBold value to intState (Action Group) Show Table Hide All: Hide Static group Show 0: Show Image 0 if intState = 0 Show 1: Show Image 1 if intState = 1 Show 2: Show Image 0 if intState = 2 Show 3: Show Image 1 if intState = 3 (Static group) Image 0 Image 1 Image 2 Image 3(On keystroke or mouse click) Toggle Select Run Set Select (On keystroke or mouse click) Toggle Bold Run Set Bold Edited By: bpitman on 2007-3-12 14:10:52
Discussions have been disabled for this post